Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve live user count #520

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Improve live user count #520

merged 9 commits into from
Jan 20, 2025

Conversation

AksLolCoding
Copy link
Contributor

Adds option to show/hide user count and improves its display

@AksLolCoding
Improve live user count
c25e599 
Adds option to show/hide user count and improves its display
@AksLolCoding
fix eslint issue
5856063
@AksLolCoding
fix eslint 2
8851cdf
@agrawal-d
Copy link
Owner

Thanks @AksLolCoding , can you hide user count by default, and fix the build / linter issues?

@AksLolCoding
Copy link
Contributor Author

@agrawal-d I fixed the lint issues and hid user count by default.

@agrawal-d
Copy link
Owner

Too many unrelated changes in package.json, please undo them.

@AksLolCoding
Copy link
Contributor Author

Sorry, I had different lint settings that cause the issue but now it is fixed.

agrawal-d
agrawal-d approved these changes Jan 20, 2025
View reviewed changes
Copy link
Owner

@agrawal-d agrawal-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@agrawal-d agrawal-d merged commit 0f8b0ab into agrawal-d:main Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrawal-d agrawal-d agrawal-d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AksLolCoding @agrawal-d